Repository navigation
chore: update cypress to 16.2.1 - #1015
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WUv8r4ui43Dk3dtH6nGpTg
Cypress 16 removed the option and warns when it is set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WUv8r4ui43Dk3dtH6nGpTg
Cypress 16 component testing requires Vite 8. vite-plugin-istanbul 7.x only supports up to Vite 7, so it moves to 9.x. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WUv8r4ui43Dk3dtH6nGpTg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
This moves the repo's Cypress dev dependency from
^15.10.0to^16.2.1and cleans up what the Cypress 16 migration guide asks for.package.json/package-lock.json: thecypressdev dependency changes to^16.2.1. Every other lockfile change is inside Cypress's own dependency tree.allowCypressEnv: falsefrom all 20test-apps/*/cypress.config.js. Cypress 16 removed the option and warns when it's set.component-vitetest app: moves tovite@^8.3.5andvite-plugin-istanbul@^9.0.1. Cypress 16 component testing requires Vite 8 and throwsViteVersionNotSupportedErroron Vite 7, andvite-plugin-istanbul7.x only supports up to Vite 7.@vitejs/plugin-react5.2 already accepts Vite 8, so it stays.Cypress.env()was removed in Cypress 16, not that it "will be."What doesn't need changing:
Cypress.expose(). Nothing inlib/,middleware/, or the test apps callsCypress.env().cy.end(),cy.exec(),execTimeout, the removed experimental options, runtimeCypress.config()changes to the viewport orblockHosts, or.coffeefiles.--envflags or plugin-optionCYPRESS_*variables in CI or scripts. TheCYPRESS_*variables in CI are install settings only.peerDependencies(cypress >=15.10.0) andengines(node >=20) are untouched, so the plugin still installs for Cypress 15 users. CI already runs on Node 22 and 24, which Cypress 16 requires.Known open item: every test app runs in the default Electron browser, which Cypress 16 marks as deprecated, so each run prints a warning. Switching to
defaultBrowser: 'chrome'would clear it, but it changes what CI exercises (Chrome now uses Cypress 16's native network handling), so it's left for a follow-up decision.Steps to test
npm ci && npm run buildnpm testandnpm run format:check. Both pass locally.npx cypress verify, thennpm run apps:test:coverage:verify. Locally, all 20 test apps pass on Cypress 16.2.1 with their coverage checks;component-vitepasses at 100% after the Vite 8 update.How has the user experience changed?
No change. The published plugin's code and its supported Cypress and Node ranges are the same; this only updates the Cypress version used to develop and test it.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WUv8r4ui43Dk3dtH6nGpTg